pranavdhanabalan commented on PR #6424: URL: https://github.com/apache/fineract/pull/6424#issuecomment-5694208104
Hello Sir, Thanks for pointing this out, I originally added the synchronization while addressing the SpotBugs IS2_INCONSISTENT_SYNC warning, since SpotBugs was reporting inconsistent synchronization around supportedCacheNames. After checking the lifecycle of supportedCacheNames, I confirmed that setSupportedCaches() is only called during Spring startup and the cache names are not modified afterward. I agree that synchronization is unnecessary here, so I'll remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
