[
https://issues.apache.org/jira/browse/FINERACT-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18116204#comment-18116204
]
MARAM SAI SWARAN commented on FINERACT-2830:
--------------------------------------------
Hi [~aleks] and [~avivijay] ,
I reviewed FINERACT-2830 in the current source. Both GET /templates/template
and GET /templates/\{id}/template return TemplateDetailsData which contains
the entities and types option arrays and the optional template object. However
both OpenAPI response annotations currently declare TemplateData.
I believe the fix is to change those two response schemas to
TemplateDetailsData and add or adjust focused coverage for the generated
OpenAPI contract if appropriate. This should correct the API specification
without changing runtime behavior.
Let me know if you agree with this scope and also any existing OpenAPI test
pattern you would prefer me to follow. If so, I will create a dedicated branch
and prepare the small fix.
> OpenAPI gaps: Admin Templates
> -----------------------------
>
> Key: FINERACT-2830
> URL: https://issues.apache.org/jira/browse/FINERACT-2830
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Aleksandar Vidakovic
> Priority: Major
> Labels: beginner-friendly
>
> h4. /templates/template
> * GetTemplatesTemplateResponse: entity, type defined as numbers instead of
> arrays
> h4. /templates/{id}/template
> * no defined type
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
