alberto-art3ch opened a new pull request, #6485:
URL: https://github.com/apache/fineract/pull/6485

   ## Description
   
   `jpaAuditingHandler` was registered as a prototype, and since Spring Data 
Commons 4.x the `AuditingHandler` constructor walks every persistent entity to 
build its auditing metadata — so every command triggered a full mapping-context 
scan (85% of JFR execution samples under a write-heavy workload; a mixed write 
run went from 18m 33s to 12m 58s after the fix).
   
   The prototype scope existed only because `markCreated`/`markModified` 
mutated the handler's `DateTimeProvider` to pick local vs UTC timestamps per 
entity; that choice now travels in a thread local, so a shared instance is safe 
and the bean goes back to singleton.
   
   Audit timestamp semantics are unchanged — the four pre-existing 
`CustomAuditingHandlerTest` cases pass unmodified — plus new tests for the 
thread-local isolation and for the bean scope.
   
   [FINERACT-2845](https://issues.apache.org/jira/browse/FINERACT-2845)
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [ ] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [ ] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [ ] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as 
resolved and set "Fix Version/s" appropriately.
   - [ ] I followed the [AI 
Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to