1cbyc opened a new pull request, #630: URL: https://github.com/apache/fineract-backoffice-ui/pull/630
## What and why Related to #569. The staff list still imported Ionic directly after its status icons moved to `app-icon`. This migrates its create and edit actions to `app-button`, preserving their router-link behavior, visual intent, tooltip, accessible name, and permission guards while removing the feature's remaining direct vendor UI import. The regression coverage checks the application-level button contract rather than Ionic internals: button type, router commands, icons, edit labels, and permission hiding. Pruning the lint baseline removes the staff list's `local/no-vendor-ui-import` suppression. ## Verification - `npm ci` — completed with 0 vulnerabilities - `npm run lint:prune` - `npm run lint` - `npm run format:check` - `npm run i18n:check` - `npm run check:icons` - `npm run check:a11y-names` - `npm run check:ui-primitives` - `npm run api:surface` - `npm test -- --watch=false` under Node 24.21.0 — 251 files, 1,576 tests passed - `npm run build` under Node 24.21.0 - `bash scripts/check-license.sh` - `playwright test --project=mocked e2e/functional-coverage.spec.ts --grep "staff create form loads"` under Node 24.21.0 — 1 passed ## Screenshots Not applicable. The existing create and edit actions retain their established visual intent; this changes the application boundary and preserves the current workflow. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] No new component, service, browser global, or imperative third-party API was introduced. - [x] User-facing strings continue to use existing translation keys. - [x] I added regression coverage for the migrated button contract. - [x] The existing mocked staff-create browser journey passes; no backend behavior changed. - [x] Commits are signed and GitHub reports the head commit as Verified. Co-authored-by: insisong <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
