shivaansh0610-LUFFY commented on PR #629: URL: https://github.com/apache/fineract-backoffice-ui/pull/629#issuecomment-5853086829
Thanks for the review. Pushed 452ebc5 addressing both blockers: 1. **Scope** — Changed `Closes #585` to `Refs #585` in the PR description; this only covers the nine Account Transfer fields, the other seven forms are still open. 2. **Accessible errors** — Added `aria-invalid` and `aria-describedby` to all nine required controls (input + selects), and each error note now has a unique `id` and `role="alert"`, following the shape you suggested. Also tightened the marker test to check each specific control instead of a raw class count, and added tests asserting the aria wiring on both an input and a required select blur. `npm run lint`, `npm run test:unit` (1582/1582), `npm run build`, `npm run i18n:check`, `npm run check:a11y-names` all pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
