shivaansh0610-LUFFY opened a new pull request, #629:
URL: https://github.com/apache/fineract-backoffice-ui/pull/629
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!-- Commits must be signed to merge — see CONTRIBUTING.md#commit-signing if
you haven't set this up. -->
## What and why
Improves the Account Transfer form by clearly marking required fields,
showing inline validation feedback on blur, and displaying a submission hint
when required fields are incomplete.
Also fixes a grid layout regression introduced during the validation changes
and adds the required translation key.
Closes #585
## Verification
- `npm run lint`
- `npm run test:unit` — 1580/1580 tests passing
- `npm run build`
- `npm run i18n:check`
- Accessibility check completed successfully.
- Verified the required-field markers, blur validation, submission hint, and
corrected layout in the UI.
- Added 6 unit tests covering the new validation behaviour.
## Screenshots
### Before
<img width="1280" height="900" alt="account-transfer-before"
src="https://github.com/user-attachments/assets/0e933f9c-ccfc-49b4-999e-027e25a364e7";
/>
https://github.com/user-attachments/assets/4ebb3739-325c-4a90-94a9-79cf757a24cb
### After
<img width="1280" height="900" alt="account-transfer-after"
src="https://github.com/user-attachments/assets/9c2672e0-6aee-4593-bfac-f313d20dc132";
/>
https://github.com/user-attachments/assets/225de3ba-9ee2-46e3-816c-5b19054420b5
Screenshots and short recordings were captured from the local development
environment.
## AI assistance (optional)
<!-- If generative AI materially assisted this contribution, optionally
state the tool or model and
the harness or workflow used. The contributor remains responsible for the
submitted change. -->
- Tool / model: Claude Sonnet 5
- Harness / workflow: Interactive code review, debugging, test review, and
PR drafting in VS Code
## Checklist
<!-- Check each item, or explain why it does not apply. -->
- [x] I did not hand-edit generated files under `src/app/api/`.
- [x] New component or service code uses the adapter boundary in
`src/app/core/adapters/` instead of direct browser globals or imperative
third-party APIs.
- [x] User-facing strings use translation keys.
- [x] I added or updated tests appropriate to this change, or explained why
tests were not needed.
- [ ] UI workflow changes include suitable e2e coverage, including
real-backend testing where relevant.
- [ ] Commits are signed — see [Commit
Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md.
- [x] I followed the [AI-assisted contributions
guidance](CONTRIBUTING.md#ai-assisted-contributions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
