Samer-Melhem-FOO opened a new pull request, #6532: URL: https://github.com/apache/fineract/pull/6532
## Description JIRA: https://issues.apache.org/jira/browse/FINERACT-2869 With `allow-backdated-transaction-before-interest-posting` disabled (pivot-date mode), the *Post Interest For Savings* job posts interest on a savings account once and then never again while the account has no new deposit or withdrawal. **Root cause:** in pivot-date mode only the transactions on or after `interest_posted_till_date` are loaded and the earlier balance is carried in as `runningBalanceOnPivotDate`. For an idle account the transaction list is empty, and `SavingsAccountInterestPostingServiceImpl#appendPostingPeriodIfAny` returned early without creating a `PostingPeriod`, so the carried balance never earned interest. **Fix:** a period without transactions is skipped only when the carried-forward balance is also zero; otherwise `PostingPeriod#createFromDTO` builds it from its existing fallback (one end-of-day balance spanning the period). The overdraft split calls keep the early return: their lists are filtered per period, so an empty list there means the period does not apply, and building a period from the carried balance would count interest twice. **Tests:** new `SavingsAccountInterestPostingServiceImplTest` (idle account after the pivot date with a carried balance gets one posting period per elapsed period with non-zero interest; with a zero balance, none). It fails on `develop` (`expected: <3> but was: <0>`) and passes with the fix. **Live check** (local PostgreSQL, business date enabled, pivot-date mode, 5% monthly-posting product, 1000 deposited on 2026-06-01): - `develop`: first job run on 2026-08-15 posts June and July; after moving the business date to 2026-10-15 with no activity, the second run posts nothing and `interestPostedTillDate` stays at 2026-08-01. - with the fix: the second run posts August and September interest and `interestPostedTillDate` advances. No API change. ## Checklist - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (no API change) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
