alberto-art3ch commented on PR #6514: URL: https://github.com/apache/fineract/pull/6514#issuecomment-5920015400
> Please review the concerns: > > * Too high max value > * Messing with precisions, -> not needed! @adamsaghy, both concerns addressed: - Max value: MAX_CALCULABLE_ANNUAL_EIR lowered from 1E+19 to 999999. It is now also validated at the entry points: annualEir on loan application/modification, and annualEir / minAnnualEir / maxAnnualEir on product create/update. An out-of-range rate is rejected with a 400 validation error where it is entered, rather than surfacing later as a "not calculable" schedule. - Precision: reverted. calculated_annual_eir stays DECIMAL(19,6), and the 0087 Liquibase changeset and its include were removed. With the cap at 999999 the existing column is wide enough, so no schema change is needed. Two small related adjustments: - The cap check is now inclusive (> cap instead of >= cap), so exactly 999999 is accepted, consistent with the validators' notGreaterThanMax. - When re-pricing the projection fails, the log level goes from debug to warn. With a lower cap, loans solved close to it can hit that path, and it should not go unnoticed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
