pwargulak commented on PR #6578: URL: https://github.com/apache/fineract/pull/6578#issuecomment-6058974661
@adamsaghy Good point. For this PR I'd propose the minimal fix: reject a `transactionDate` earlier than the loan's last non-reversed monetary transaction (accruals excluded). Then nothing after the waiver can have touched the charge, so its amount is correct. Making WAIVE_CHARGES part of reverse-replay do sound as better, general solution, but it's a bigger change, I would make new ticket for that if thats OK? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
