pwargulak commented on PR #6578: URL: https://github.com/apache/fineract/pull/6578#issuecomment-6090676351
Thanks @adamsaghy, I thought about your scenarios more and I think you are right, with a partly paid charge and a reversed or backdated repayment the waived amount can be wrong, and the guard I proposed only hides part of it. The proper fix is to make the waive part of reverse-replay, which is a bigger change than this PR. In the meantime our own project went a different way and we don't depend on this anymore, so I don't want to keep a half-solution open here. I'm closing this PR. I'll leave a note on FINERACT-2896 with the scenarios so whoever picks it up has them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
