budaidev commented on PR #6601: URL: https://github.com/apache/fineract/pull/6601#issuecomment-6074309439
Thanks @galovics , all addressed. The seven `WorkingCapitalNearBreachEvaluation.feature` scenarios are rewritten to the new contract, the "immutable" titles are renamed, and the PR description now calls out the behaviour change for API and `WorkingCapitalLoanNearBreachChangeBusinessEvent` consumers. The snapshot/baseline logic moved out of the schedule service into `WorkingCapitalLoanNearBreachBaseline` and `WorkingCapitalLoanNearBreachRederivation`, with focused unit tests for `isStale`/`hasChanged`. Repayment and undo now check `isBreachDisabled` once and pass the resolved parameters in, the COB path delegates to the same `rederiveNearBreach`, and the `*NearBreach` methods are renamed by intent (`evaluateNearBreachOnCob`, `rederiveNearBreach`, `resolveNearBreachValue`). On the undo question, yes: charge waiver undo, discount fee adjustment undo, undo write-off and a charge that reopens a closed loan could all reopen it without a re-derive, so they now go through one `rederiveNearBreachIfReopened` helper (charge adjustment undo was already covered by the generic undo). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
