mariiaKraievska commented on PR #6585: URL: https://github.com/apache/fineract/pull/6585#issuecomment-6124695978
@budaidev Can you place review the below? 1. LoanTransactionTypeExternalEvents.java: Please register LOAN_WITHDRAWAL → LoanTransactionLoanWithdrawalPostBusinessEvent, same as contract termination. Otherwise undo LoanAdjustTransactionBusinessEvent has no governing type and posts via orElse(true) even when the withdrawal post event is disabled. 2. (product/AC) validator cannot.be.before.business.date: Could you confirm the past-date AC? The ticket allows past if last monetary/charge, but the note and this PR reject any date before business date. Please either update the AC or implement the past-date rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
