MokuLakshithReddy commented on code in PR #155: URL: https://github.com/apache/fineract-consumer-facing/pull/155#discussion_r4234272126
########## consumer/src/test/java/org/apache/fineract/consumer/savings/command/service/SavingsCommandServiceImplTest.java: ########## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fineract.consumer.savings.command.service; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.ArgumentMatchers.isNull; +import static org.mockito.Mockito.inOrder; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.never; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import feign.FeignException; +import java.math.BigDecimal; +import java.time.LocalDate; +import java.util.UUID; +import org.apache.fineract.consumer.infrastructure.access.data.ConsumerAction; +import org.apache.fineract.consumer.infrastructure.access.service.AccessPolicyEvaluator; +import org.apache.fineract.consumer.infrastructure.access.service.OwnedAccountsCache; +import org.apache.fineract.consumer.infrastructure.fineractclient.generated.api.SavingsAccountApi; +import org.apache.fineract.consumer.infrastructure.fineractclient.generated.model.PostSavingsAccountsAccountIdResponse; +import org.apache.fineract.consumer.infrastructure.fineractclient.generated.model.PostSavingsAccountsResponse; +import org.apache.fineract.consumer.infrastructure.fineractclient.generated.model.PutSavingsAccountsAccountIdResponse; +import org.apache.fineract.consumer.infrastructure.idempotency.service.IdempotencyKeyDeriver; +import org.apache.fineract.consumer.infrastructure.idempotency.service.IdempotencyKeyHolder; +import org.apache.fineract.consumer.savings.command.data.ModifySavingsApplicationCommand; +import org.apache.fineract.consumer.savings.command.data.SavingsApplicationCommandData; +import org.apache.fineract.consumer.savings.command.data.SubmitSavingsApplicationCommand; +import org.apache.fineract.consumer.savings.command.data.WithdrawSavingsApplicationCommand; +import org.apache.fineract.consumer.savings.command.exception.SavingsCommandInProgressException; +import org.apache.fineract.consumer.savings.command.exception.SavingsCommandUpstreamUnavailableException; +import org.apache.fineract.consumer.user.query.data.UserQueryData; +import org.apache.fineract.consumer.user.query.data.UserStatus; +import org.apache.fineract.consumer.user.query.service.UserQueryService; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.InOrder; +import org.mockito.InjectMocks; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; +import org.springframework.http.HttpStatus; +import org.springframework.security.oauth2.jwt.Jwt; + +@ExtendWith(MockitoExtension.class) +class SavingsCommandServiceImplTest { + + private static final UUID PUBLIC_ID = UUID.fromString("3f2c8a1e-0000-4000-8000-000000000001"); + private static final Long CLIENT_ID = 42L; + private static final Long SAVINGS_ID = 5L; + private static final String EMAIL = "[email protected]"; + private static final String IDEMPOTENCY_KEY = "savings-op-key-1"; + + @Mock + private UserQueryService userQueryService; + + @Mock + private AccessPolicyEvaluator accessPolicyEvaluator; + + @Mock + private OwnedAccountsCache ownedAccountsCache; + + @Mock + private IdempotencyKeyHolder idempotencyKeyHolder; + + @Mock + private SavingsAccountApi savingsAccountApi; + + @InjectMocks + private SavingsCommandServiceImpl service; + + private static Jwt jwt() { + return Jwt.withTokenValue("token") + .header("alg", "none") + .subject(PUBLIC_ID.toString()) + .claim("scope", "read") + .build(); + } + + private static UserQueryData user() { + return UserQueryData.builder() + .id(1L) + .publicId(PUBLIC_ID) + .fineractClientId(CLIENT_ID) + .email(EMAIL) + .status(UserStatus.BOUND) + .build(); + } + + private static SubmitSavingsApplicationCommand submitCommand() { + return SubmitSavingsApplicationCommand.builder() + .productId(1L) + .submittedOnDate(LocalDate.of(2026, 7, 1)) + .nominalAnnualInterestRate(new BigDecimal("3.5")) + .externalId("ext-123") + .idempotencyKey(IDEMPOTENCY_KEY) + .build(); + } + + @Test + void submitAuthorizesSavingsApplicationSubmit() { + Jwt jwt = jwt(); + when(userQueryService.findByPublicId(PUBLIC_ID)).thenReturn(user()); + when(savingsAccountApi.submitSavingsApplication(any())) Review Comment: Done. Added comprehensive ArgumentCaptor assertions in SavingsCommandServiceImplTest for PostSavingsAccountsRequest, PutSavingsAccountsAccountIdRequest, and PostSavingsAccountsAccountIdRequest checking all mapped and default fields (including absent optional fields). Also added ccessPolicyEvaluator.authorize(...) verifications on modify/withdraw, and dedicated tests verifying savingsAccountApi is never called when access is denied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
