Aman-Mittal commented on PR #155: URL: https://github.com/apache/fineract-consumer-facing/pull/155#issuecomment-6356925246
> Hi @Aman-Mittal, > > All CI checks are passing! Here is a summary of the changes implemented in response to your review: > > 1. **ArchUnit Seam & Frozen Store Integrity**: > - Reverted all hand-edited entries in `archunit_store/feature-classes-do-not-depend-on-the-generated-fineract-feign-clients-fd283b04.txt`. > - Created the narrow interface `SavingsAccountApiClient` and implementation `SavingsAccountApiClientImpl` under `org.apache.fineract.consumer.infrastructure.fineractclient.service`. > - Refactored `SavingsCommandServiceImpl` to depend strictly on `SavingsAccountApiClient` instead of the generated Feign client directly. > > 2. **Spec Sanitizer & Architecture Docs Clean-Up**: > - Dropped the no-op `addMissingSavingsAccountCommandFields` method and its invocation from `consumer/build.gradle`. > - Reverted the corresponding sentence in `docs/consumer/architecture/fineract-integration.adoc`. > > 3. **Deposit Type & State Validations**: > - Added deposit type verification in `SavingsCommandServiceImpl` before modifying or withdrawing an account to verify `depositType = 100` (savings account). > > 4. **Bean Validation Tests**: > - Added constraint validation tests in `SavingsCommandControllerTest` covering `@NotNull`, `@Positive` on `productId` and dates, and `@Size(max = 1000)` on the withdrawal note. > > 5. **Cucumber E2E Scenario Enhancements**: > - Renamed feature title in `savings.feature` to `Feature: Consumer savings reads and applications` and trimmed trailing blank lines. > - Added IDOR / ownership scenarios ensuring that modifying or withdrawing another client's savings account returns 403 `error.msg.consumer.savings.command.access.denied`. > - Added state transition scenarios covering invalid withdrawal attempts on active accounts and already-withdrawn accounts. > - Added meaningful assertions on modified and withdrawn accounts by re-reading the account state. > > 6. **Scope Alignment**: > - Updated the PR description from "Closes #144" to "Part of #144" so that the remaining self-service scope and frontend flows can be tracked in subsequent issues. > > Could you please review these updates when you have a moment? Thanks! Give me some time. Busy in a lot of stuff right now doing in parallel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
