mariiaKraievska commented on code in PR #6588: URL: https://github.com/apache/fineract/pull/6588#discussion_r4247963589
########## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/DefaultScheduledDateGenerator.java: ########## Review Comment: @Cocoa-Puffs Could you please confirm one AC14 point for progressive loans? generateRepaymentPeriods still applies adjustRepaymentDate only to the last installment (pre-existing). AC14 says working-day/holiday adjustment then applies “as today” — so intermediate progressive due dates after FIRST_DAY_OF_NEXT_MONTH stay on the strategy date even if that day is non-working, while cumulative would move them. Example: disbursed 31 Jan 2025, 3 months, FIRST_DAY_OF_NEXT_MONTH, weekdays only / move to next working day. Strategy gives 1 Mar 2025 (Sat); cumulative becomes 3 Mar (testRolledDateIsMovedOffNonWorkingDay), progressive would keep 1 Mar. There is no progressive counterpart of that test in this PR. Is that the intended behaviour here, or should progressive be aligned with cumulative? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
