rshdhere opened a new pull request, #6637: URL: https://github.com/apache/fineract/pull/6637
`ContentPolicyException` extended the bare `AbstractPlatformException`, which has no exception mapper, so a rejected upload (file type not on the whitelist, declared/detected mime type mismatch, path traversal) fell through to `DefaultExceptionMapper` and returned HTTP 500. It now extends `PlatformApiDataValidationException`, so the client gets a 400 with the policy message on the "file" parameter. ## Description JIRA: https://issues.apache.org/jira/browse/FINERACT-2935 `ContentPolicyException` extended the bare `AbstractPlatformException`, which has no exception mapper, so a document upload rejected by a content policy (file type not on the whitelist, declared vs. detected mime type mismatch, path traversal) fell through to `DefaultExceptionMapper` and returned HTTP 500. It now extends `PlatformApiDataValidationException`, so the client gets a 400 with the policy message on the `file` parameter. Image uploads are unaffected (they already wrap this exception in `DocumentInvalidRequestException`). Tests: - `ContentPolicyExceptionTest`: the exception maps to 400 with the expected error code, parameter and message. - `FeignDocumentTest.testCreateDocumentNotAllowedFileType`: uploading a `.txt` returns 400. Checked manually against a local instance: `.txt` upload → 400 "File name not allowed: test.txt"; GIF uploaded as `image/png` → 400 mime mismatch; valid PNG → 200. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [X] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [X] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [X] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [X] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [X] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
