jenny1371 commented on PR #6590: URL: https://github.com/apache/fineract/pull/6590#issuecomment-6262537851
Thanks for the careful review, and for catching the failed mark-as-sent case: you're right that the loop would re-read and resend the same batch there. It's a small fix, but I'm going to close this PR instead of making it. My measurements: with the default batch size (1000), one batch per run sends 1,000 events per minute; with `max-batches-per-run=20`, a 12,000-event backlog was sent in one run in about 4 s. But raising `external-event-batch-size` alone gave a similar effect (batch size 10000: the remaining 7,488 events were sent in one run in 1.08 s). So the new setting adds little over the existing configuration, and I don't think it's worth the extra setting and loop logic for the maintainers. Thanks again for the time you spent on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
