[
https://issues.apache.org/jira/browse/FINERACT-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129336#comment-18129336
]
Aarti Panchal commented on FINERACT-2974:
-----------------------------------------
PR: https://github.com/apache/fineract/pull/6702
> Updating a hook does not change its name or active flag
> -------------------------------------------------------
>
> Key: FINERACT-2974
> URL: https://issues.apache.org/jira/browse/FINERACT-2974
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Aarti Panchal
> Priority: Major
>
> PUT /hooks/\{hookId} with a new displayName or isActive returns 200 and lists
> them under "changes", but the hook keeps its old name and active flag
> (checked in m_hook).
> HookWritePlatformServiceImpl.updateHook adds displayName and isActive to the
> changes map but never sets them on the Hook entity, unlike events and config.
> It also reports both as changed (and saves) when the request leaves them out,
> because it compares null with the stored value.
> Fix: set them on the hook when the request provides them, and leave them
> alone when it does not.
> Found while building the Manage Hooks pages of the Mifos X React web app.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
