rymghosn commented on PR #6286: URL: https://github.com/apache/fineract/pull/6286#issuecomment-6335647962
@adamsaghy Thanks, confirmed and fixed in e74c4a4a50. - **Second pass with names of 30+ characters:** reproduced on PostgreSQL. A 35-character duplicate whose generated `<first 30> (<id>)` was already taken gave `could not create unique index "uq_m_tax_component_name"`. The second pass now appends the id to `SUBSTRING(name, 1, 25)`, as you suggested, for both tables. It always writes a value different from the first pass's: for a short original name the result is `<name> (<id>) (<id>)`, otherwise it's shorter. Re-checked with the clashing row older and newer than the renamed one, for names of 3, 28, 35 and 40 characters. All changesets apply, and both constraints are created. - **Numbering:** renumbered to `0261_add_unique_constraint_tax_component_and_group_name.xml`, after `0258`–`0260` on `develop`. - **Rebase:** rebased onto the latest `develop`, and the changelog conflict is resolved. `TaxNameUniquenessTest` and the existing tax ITs pass against a booted PostgreSQL instance where `0261` ran on existing tax data. I've updated the PR description to match. Could you please re-review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
