Dhanno98 commented on PR #6448: URL: https://github.com/apache/fineract/pull/6448#issuecomment-6345869752
> * Only `redeemShares` is used. `additional-shares`, `approve` and `reject` have no caller and no test - YAGNI, drop them with their Swagger classes, delegate methods and interface entries (about 90 lines). If any stay, they need tests, and `redeem` as a verb path next to a noun `additional-shares` does not match the existing command naming (`redeemshares`). I agree that if V2 approach is retained, only `redeemshares` is required by this particular test migration. I introduced the four V2 operations because the `requestedShares` ambiguity exists across the existing share account commands. If the maintainers decide to proceed with the V2 approach, I will remove the other three operations that are not used by `ShareAccountChargeRoundingTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
