galovics opened a new pull request, #6725: URL: https://github.com/apache/fineract/pull/6725
"Update Non Performing Assets" (cron 00:00) and "Update Loan Arrears Ageing" (cron 00:01) have no ordering guarantee between them - scheduler_group/task_priority are Quartz grouping metadata, not an execution-order contract. UpdateNpaTasklet determines NPA status by joining m_loan_arrears_aging, so when NPA runs before arrears ageing has refreshed that table for the day, a loan that newly crosses the NPA threshold is missed and only gets flagged on the following day's run. Add a changeset (rather than editing the already-applied 0002 seed) that moves the NPA job's cron to 00:02, after arrears ageing has run, for tenants still on the seeded default cron - a tenant that customized it via the scheduler API keeps its own schedule. This doesn't add a hard ordering guarantee - Fineract's scheduler has no cross-job dependency primitive - but the actual run state (currently running, active, last run status/time) is already visible per-job via the existing Jobs admin screen if the 1-minute gap ever proves insufficient for a given tenant; no need to duplicate that into the tasklet itself ahead of an observed problem. Also fixed testUpdateOverdueDaysForNPA, which only passed because method-name ordering happened to run the arrears-ageing test first; it now runs that job explicitly for clarity. Assisted-By: Claude Code-Sonnet-5 ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [ ] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [ ] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
