ym0506 opened a new pull request, #6731: URL: https://github.com/apache/fineract/pull/6731
## Description `TaxUtils.splitTax` / `splitTaxData` multiplied `amount.doubleValue()` by the percentage and divided by 100 in `double`, then rounded with the tenant rounding mode. For exact values on a rounding boundary the double result is slightly below the boundary, so the tax was one minor unit too low. Examples: 4.10 at 15 % gave 0.61 instead of 0.62 (HALF_EVEN), 5250 at 1.4 % gave 73 instead of 74 (HALF_EVEN), and 5500 at 1.4 % gave 76 instead of 77 (DOWN). Details and a scan of affected amounts are on [FINERACT-2988](https://issues.apache.org/jira/browse/FINERACT-2988). This change computes `amount * percentage / 100` exactly with `BigDecimal` and rounds once to the requested scale. Other results are unchanged. I did not reuse `MathUtil.percentageOf` because it rounds to a `MathContext` precision first and returns zero for non-positive amounts, which would change behavior. Tests: - New `TaxUtilsTest` (6 cases) covering `splitTax` and `splitTaxData` with HALF_EVEN ties, a zero-decimal currency, and DOWN on an exact whole amount. Before the fix, 5 of the 6 fail. The existing `ChargeTaxApplicationServiceTest` amounts (e.g. 1000 at 16 %) are exactly representable in `double`, so they did not detect this. - `./gradlew :fineract-tax:test` passes (17 tests); `spotlessCheck` and `checkstyleMain`/`checkstyleTest` pass for `fineract-tax`; `SavingsAccountWithHoldTaxNullAmountTest` passes. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes (not applicable: no API changes) - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). - [x] If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately. - [x] I followed the [AI Policy](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#ai-policy). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
