cmandib commented on PR #6670: URL: https://github.com/apache/fineract/pull/6670#issuecomment-6497036894
@adamsaghy These failures come from develop, not from this PR. I've fixed them here in a separate commit: - `AccountTransfersWritePlatformServiceImplTest` (2 tests): #6698 (FINERACT-2639) added an office-hierarchy check to undo(), but the tests didn't mock the offices or `PlatformSecurityContext`. - `LoanChargeWritePlatformServiceImplTest.shouldHandAppliedOverduePenaltiesToRealTimeAccrualAfterReprocessing`: #6698 changed setUp() to stub `assembleFromInUserScope`, but the overdue-charge job still calls `assembleFrom`, so `loan` was null. I confirmed all three fail the same way on develop (a7b3763570) with only your constructor fix applied, and pass with this commit. develop's own CI will stay red until these fixes are on it. Could you approve the workflow run? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
