Samer-Melhem-FOO commented on PR #6742:
URL: https://github.com/apache/fineract/pull/6742#issuecomment-6519040837

   @adamsaghy thanks. I merged #6744 into this PR as you suggested (commit 
8f8f00df2f, FINERACT-2998), so on cumulative schedules accruals are no longer 
assigned to installments by date: a run posts one accrual dated on the run 
date, and reprocessing fills accruals into installments in order and reverses 
only on real over-accrual. The branch is rebased on current develop.
   
   **Undo:** income recognised on receipt is reversed when the repayment is 
undone, which is the cash-basis treatment for an NPA loan. For an open NPA 
loan, the cumulative reprocess now caps accrued interest per installment at the 
larger of what was accruable when normal accrual stopped (`accruedTill`, which 
does not move while NPA) and the interest actually paid. Undoing the repayment 
lowers the paid interest, so the on-receipt accrual is reversed (b81fae1d6d).
   
   **Integration test:** `LoanNpaInterestIncomeOnReceiptTest` (cumulative 
periodic accrual, 12 daily installments, NPA after 5 overdue days):
   - after the NPA repayment and after the closing repayment: Interest 
Receivable = 0 and Interest Income = interest paid;
   - after undoing the NPA repayment: both are back to their values before it.
   
   On current develop the first test fails (Interest Receivable -4.22 after the 
NPA repayment); on this branch both pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to