[
https://issues.apache.org/jira/browse/FINERACT-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135531#comment-18135531
]
Thevinu Jayasekara commented on FINERACT-2982:
----------------------------------------------
Hi all,
cc: [~adamsaghy] [~arnoldgalovics] for visibilty.
To keep the remaining work for this ticket clear:
* Account activation (savings / FD / RD): covered by [~danhan] in
[#6777|https://github.com/apache/fineract/pull/6777]. I'm dropping it from my
branch.
* Capitalized income (addCapitalizedIncome, capitalizedIncomeAdjustment): over
to [~sanvinaik], as requested above.
I'm working on the remaining parts and will raise them as one PR:
* Loans: buy-down fee, re-age / undo re-age, re-amortize / undo re-amortize,
interest pause (create / update / delete), and contract termination / loan
withdrawal plus their undo (LoanEarlyTerminationServiceImpl).
* Share accounts: all write operations on existing accounts (approve, reject,
activate, apply / approve / reject additional shares, redeem, close, undo
approval)
* Working-capital loans: disbursal, undo disbursal, repayment, goodwill
credit, payout refund, credit balance refund, discount fee and its adjustment,
transaction undo / adjust / adjust-by-delta, charge add / adjust / waive,
charge-off / undo, write-off / undo, and recovery payment
The implementation is done, and I'm running the integration tests now. I'll
link the PR here once it's up.
> Extend office-hierarchy access checks to remaining monetary operations
> ----------------------------------------------------------------------
>
> Key: FINERACT-2982
> URL: https://issues.apache.org/jira/browse/FINERACT-2982
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Thevinu Jayasekara
> Priority: Major
>
> FINERACT-2639 (PR [#6698|https://github.com/apache/fineract/pull/6698]) added
> office-hierarchy checks to loan, savings, account transfer, fixed/recurring
> deposit and collection sheet transactions. A user can only post them on
> accounts in their own office or a child office.
> The following operations can still create money-bearing transactions on
> accounts outside
> the user's office hierarchy:
> * Account activation that posts an initial deposit: savings, fixed deposit,
> recurring deposit
> (SavingsAccountWritePlatformServiceJpaRepositoryImpl.activate,
> DepositAccountWritePlatformServiceJpaRepositoryImpl.activateFDAccount /
> activateRDAccount)
> * Capitalized income (CapitalizedIncomeWritePlatformServiceImpl)
> * Buy-down fee (BuyDownFeeWritePlatformServiceImpl)
> * Re-age and re-amortize (LoanReAgingService, LoanReAmortizationService)
> * Interest pause (InterestPauseWritePlatformServiceImpl)
> * Contract termination (LoanContractTerminationServiceImpl)
> * Working-capital loans: repayment, charge-off and related write services in
> fineract-working-capital-loan
> * Share accounts (ShareAccountWritePlatformServiceJpaRepositoryImpl)
> Expected: these user-triggered operations use the same in-user-scope loaders
> as FINERACT-2639, so a user outside the account's office hierarchy gets a
> 403. Scheduled jobs and internal reversals stay unchanged.
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
