[
https://issues.apache.org/jira/browse/FINERACT-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135894#comment-18135894
]
Sanvi Abhijit Naik commented on FINERACT-2982:
----------------------------------------------
[~thevinu]
I've opened a PR addressing this issue: [FINERACT-2982 PR
#6799|https://github.com/apache/fineract/pull/6799].
The changes enforce user office-hierarchy validation for capitalized income
addition and adjustment operations, along with an integration test covering
both scenarios.
This is my first contribution to Apache Fineract, so I'd appreciate it if you
could take a look when you get a chance and let me know if anything needs to be
improved.
Thank you!
> Extend office-hierarchy access checks to remaining monetary operations
> ----------------------------------------------------------------------
>
> Key: FINERACT-2982
> URL: https://issues.apache.org/jira/browse/FINERACT-2982
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Thevinu Jayasekara
> Priority: Major
>
> FINERACT-2639 (PR [#6698|https://github.com/apache/fineract/pull/6698]) added
> office-hierarchy checks to loan, savings, account transfer, fixed/recurring
> deposit and collection sheet transactions. A user can only post them on
> accounts in their own office or a child office.
> The following operations can still create money-bearing transactions on
> accounts outside
> the user's office hierarchy:
> * Account activation that posts an initial deposit: savings, fixed deposit,
> recurring deposit
> (SavingsAccountWritePlatformServiceJpaRepositoryImpl.activate,
> DepositAccountWritePlatformServiceJpaRepositoryImpl.activateFDAccount /
> activateRDAccount)
> * Capitalized income (CapitalizedIncomeWritePlatformServiceImpl)
> * Buy-down fee (BuyDownFeeWritePlatformServiceImpl)
> * Re-age and re-amortize (LoanReAgingService, LoanReAmortizationService)
> * Interest pause (InterestPauseWritePlatformServiceImpl)
> * Contract termination (LoanContractTerminationServiceImpl)
> * Working-capital loans: repayment, charge-off and related write services in
> fineract-working-capital-loan
> * Share accounts (ShareAccountWritePlatformServiceJpaRepositoryImpl)
> Expected: these user-triggered operations use the same in-user-scope loaders
> as FINERACT-2639, so a user outside the account's office hierarchy gets a
> 403. Scheduled jobs and internal reversals stay unchanged.
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
