alberto-art3ch commented on PR #6727: URL: https://github.com/apache/fineract/pull/6727#issuecomment-6551678420
> Hi @alberto-art3ch, thanks for the PR. > > The fix itself looks right to me. That INSERT was the only string-built statement in the tasklet (the `last_run_date` UPDATE was already bound, and the history read side in `StandingInstructionHistoryReadPlatformServiceImpl` binds its filters too), so this closes it. Binding the amount as `BigDecimal` instead of `doubleValue()` is a nice catch as well. > > One thing though. The description says there's a new `SchedulerJobsTestResults#testExecuteStandingInstructionsJobRecordsFailedTransferInHistory` IT plus `SchedulerJobHelper#executeAndAwaitJobStatus` and `StandingInstructionsHelper#deleteStandingInstruction`, but the PR only has 2 files: the tasklet and the unit test. Did you forget to push them? Also the "Transaction behaviour of a failed run" section still has the placeholder text in it. > > I'd actually like to see that IT, because it's the one that answers the question in that placeholder: does the successful instruction's history row and transfer survive next to the failed one, or does the `JobExecutionException` at the end roll the whole run back? Either push it, or drop those parts from the description so it matches what's actually in here. > > Thanks. Thanks Arnold, right on both: the IT was never pushed and the placeholder stayed in. Fixed now. - New IT `SchedulerJobsTestResults#testExecuteStandingInstructionsJobFailedTransferRollsBackTheWholeRun`: one unfunded and one funded instruction in the same run. Only new helper is `StandingInstructionsHelper#deleteStandingInstruction`. - Description rewritten to match the diff. On your question: the step is one transaction (`.tasklet(tasklet, transactionManager)` and `transferFunds` is `@Transactional`), so the `JobExecutionException` at the end rolls back the whole run: the successful transfer, both history rows and `last_run_date`. The IT asserts that. Pre-existing, not changed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
