[ https://issues.apache.org/jira/browse/FLINK-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310996#comment-14310996 ]
ASF GitHub Bot commented on FLINK-785: -------------------------------------- Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/370#issuecomment-73388209 Looks good in general. You need to make sure though, that you obey the execution object re-usage settings. That basically means you need to pay attention to the objects that you give to and receive from the user code and possibly copy them to new objects (see FLINK-1285 and @aljoscha's commits for details). > Add Chained operators for AllReduce and AllGroupReduce > ------------------------------------------------------ > > Key: FLINK-785 > URL: https://issues.apache.org/jira/browse/FLINK-785 > Project: Flink > Issue Type: Improvement > Reporter: GitHub Import > Labels: github-import > Fix For: pre-apache > > > Because the operators `AllReduce` and `AllGroupReduce` are used both for the > pre-reduce (combiner side) and the final reduce, they would greatly benefit > from a chained version. > ---------------- Imported from GitHub ---------------- > Url: https://github.com/stratosphere/stratosphere/issues/785 > Created by: [StephanEwen|https://github.com/StephanEwen] > Labels: runtime, > Milestone: Release 0.6 (unplanned) > Created at: Sun May 11 17:41:12 CEST 2014 > State: open -- This message was sent by Atlassian JIRA (v6.3.4#6332)