[
https://issues.apache.org/jira/browse/FLINK-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316489#comment-14316489
]
ASF GitHub Bot commented on FLINK-785:
--------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/370#issuecomment-73913500
Hi @zentol,
I had a look at your PR and the failing test case. The test was in place to
ensure that objects are reused. For that the functions were implemented in a
way that they will produce wrong results if objects are reused (therefore the
unexpected result of 100 instead of 60). The problem was caused by the
CollectionInputFormat which sends out different objects (instead of reusing the
same object). When I changed that behavior and added some fixes to the
ChainedAllReduceDriver, all tests pass.
I will open a PR against your branch.
> Add Chained operators for AllReduce and AllGroupReduce
> ------------------------------------------------------
>
> Key: FLINK-785
> URL: https://issues.apache.org/jira/browse/FLINK-785
> Project: Flink
> Issue Type: Improvement
> Reporter: GitHub Import
> Assignee: Chesnay Schepler
> Labels: github-import
> Fix For: pre-apache
>
>
> Because the operators `AllReduce` and `AllGroupReduce` are used both for the
> pre-reduce (combiner side) and the final reduce, they would greatly benefit
> from a chained version.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/785
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: runtime,
> Milestone: Release 0.6 (unplanned)
> Created at: Sun May 11 17:41:12 CEST 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
