[
https://issues.apache.org/jira/browse/FLINK-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348370#comment-14348370
]
ASF GitHub Bot commented on FLINK-1512:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/426#discussion_r25846058
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -64,15 +66,25 @@
private transient int commentCount;
private transient int invalidLineCount;
+
+ private PojoTypeInfo<OUT> pojoTypeInfo = null;
public CsvInputFormat(Path filePath) {
super(filePath);
- }
+ }
+
+ public CsvInputFormat(Path filePath, PojoTypeInfo<OUT> pojoTypeInfo) {
+ super(filePath);
+
+ Preconditions.checkNotNull(pojoTypeInfo, "The TypeInformation
is required for getting the POJO fields.");
+ this.pojoTypeInfo = pojoTypeInfo;
+ setAccessibleToField();
+ }
public CsvInputFormat(Path filePath, Class<?> ... types) {
--- End diff --
Yes, if we go for the more general TypeInformation we need to check whether
it is a TupleTypeInfo or PojoTypeInfo and can get rid of one pair of
constructors. Actually, I think both solutions are fine.
> Add CsvReader for reading into POJOs.
> -------------------------------------
>
> Key: FLINK-1512
> URL: https://issues.apache.org/jira/browse/FLINK-1512
> Project: Flink
> Issue Type: New Feature
> Components: Java API, Scala API
> Reporter: Robert Metzger
> Assignee: Chiwan Park
> Priority: Minor
> Labels: starter
>
> Currently, the {{CsvReader}} supports only TupleXX types.
> It would be nice if users were also able to read into POJOs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
