[ 
https://issues.apache.org/jira/browse/FLINK-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348700#comment-14348700
 ] 

ASF GitHub Bot commented on FLINK-1512:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/426#issuecomment-77358774
  
    Those are very good points! Having an annotation for POJO fields to define 
their order in the PojoTypeInfo (and therefore the order in which the fields 
are mapped to CSV fields) is a nice idea.
    
    The String[] parameter to select POJO fields would still be good because it
    - makes the POJO type and the CSV field independent of each other and
    - allows to fill only a subset of POJO fields.
    
    Having a way to provide logic to parse a String into a 
custom/not-natively-supported type is also important for POJOs. I would 
however, make that independent of the POJO and add it as a parameter to the 
CsvReader. That way you don't need to touch existing POJO code and make it 
again independent of the data source (imagine CSV files with different date 
formats).


> Add CsvReader for reading into POJOs.
> -------------------------------------
>
>                 Key: FLINK-1512
>                 URL: https://issues.apache.org/jira/browse/FLINK-1512
>             Project: Flink
>          Issue Type: New Feature
>          Components: Java API, Scala API
>            Reporter: Robert Metzger
>            Assignee: Chiwan Park
>            Priority: Minor
>              Labels: starter
>
> Currently, the {{CsvReader}} supports only TupleXX types. 
> It would be nice if users were also able to read into POJOs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to