Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/530#discussion_r27104700
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
@@ -1425,11 +1425,9 @@ public static boolean isClassType(Type t) {
}
private static boolean sameTypeVars(Type t1, Type t2) {
- if (!(t1 instanceof TypeVariable) || !(t2 instanceof
TypeVariable)) {
- return false;
- }
- return ((TypeVariable<?>)
t1).getName().equals(((TypeVariable<?>)t2).getName())
- && ((TypeVariable<?>)
t1).getGenericDeclaration().equals(((TypeVariable<?>)t2).getGenericDeclaration());
+ return !(!(t1 instanceof TypeVariable) || !(t2 instanceof
TypeVariable)) &&
+ ((TypeVariable<?>)
t1).getName().equals(((TypeVariable<?>) t2).getName()) &&
+ ((TypeVariable<?>)
t1).getGenericDeclaration().equals(((TypeVariable<?>)
t2).getGenericDeclaration());
--- End diff --
Not sure if this change improves the readability of the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
