Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/530#discussion_r27135686
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/RegularPactTask.java
 ---
    @@ -525,7 +525,9 @@ protected void run() throws Exception {
                                try {
                                        FunctionUtils.closeFunction(this.stub);
                                }
    -                           catch (Throwable t) {}
    +                           catch (Throwable t) {
    +                                   // do nothing
    +                           }
                        }
    --- End diff --
    
    The javadocs comment describe as to why we do a catch all and suppress all 
exceptions/errors. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to