[ https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501353#comment-14501353 ]
ASF GitHub Bot commented on FLINK-1523: --------------------------------------- Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/537#discussion_r28643920 --- Diff: flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java --- @@ -138,69 +146,46 @@ public void setInput(DataSet<Vertex<VertexKey, VertexValue>> inputData) { if (this.initialVertices == null) { --- End diff -- I find the new logic of this method a bit confusing. Why do you set some configuration parameters here (degrees and direction) and the rest in the helper methods? As far as I understand, you have 2 cases that matter here: the degrees option is set or not. This defines whether you create a simple vertex or you augment it with degree information, right? > Vertex-centric iteration extensions > ----------------------------------- > > Key: FLINK-1523 > URL: https://issues.apache.org/jira/browse/FLINK-1523 > Project: Flink > Issue Type: Improvement > Components: Gelly > Reporter: Vasia Kalavri > Assignee: Andra Lungu > > We would like to make the following extensions to the vertex-centric > iterations of Gelly: > - allow vertices to access their in/out degrees and the total number of > vertices of the graph, inside the iteration. > - allow choosing the neighborhood type (in/out/all) over which to run the > vertex-centric iteration. Now, the model uses the updates of the in-neighbors > to calculate state and send messages to out-neighbors. We could add a > parameter with value "in/out/all" to the {{VertexUpdateFunction}} and > {{MessagingFunction}}, that would indicate the type of neighborhood. -- This message was sent by Atlassian JIRA (v6.3.4#6332)