[ 
https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504706#comment-14504706
 ] 

ASF GitHub Bot commented on FLINK-1523:
---------------------------------------

Github user andralungu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/537#discussion_r28764335
  
    --- Diff: 
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
 ---
    @@ -40,7 +42,37 @@
        VertexValue extends Serializable, Message> implements Serializable {
     
        private static final long serialVersionUID = 1L;
    -   
    +
    +   // 
--------------------------------------------------------------------------------------------
    +   //  Attributes that allow vertices to access their in/out degrees and 
the total number of vertices
    +   //  inside an iteration.
    +   // 
--------------------------------------------------------------------------------------------
    +
    +   private long numberOfVertices = -1L;
    +
    +   public long getNumberOfVertices() throws Exception{
    +           if (numberOfVertices == -1) {
    +                   throw new InaccessibleMethodException("The number of 
vertices option is not set");
    +           }
    +           return numberOfVertices;
    +   }
    +
    +   void setNumberOfVertices(long numberOfVertices) {
    +           this.numberOfVertices = numberOfVertices;
    +   }
    +
    +   
//---------------------------------------------------------------------------------------------
    +
    +   private boolean optDegrees;
    +
    +   public boolean isOptDegrees() {
    --- End diff --
    
    Are you talking about the getters? To my knowledge, these are public. 
Otherwise, they would be totally unusable. 
    If you're talking about the default setters, I needed to see them in the 
entire package. But they are not public. 


> Vertex-centric iteration extensions
> -----------------------------------
>
>                 Key: FLINK-1523
>                 URL: https://issues.apache.org/jira/browse/FLINK-1523
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>            Reporter: Vasia Kalavri
>            Assignee: Andra Lungu
>
> We would like to make the following extensions to the vertex-centric 
> iterations of Gelly:
> - allow vertices to access their in/out degrees and the total number of 
> vertices of the graph, inside the iteration.
> - allow choosing the neighborhood type (in/out/all) over which to run the 
> vertex-centric iteration. Now, the model uses the updates of the in-neighbors 
> to calculate state and send messages to out-neighbors. We could add a 
> parameter with value "in/out/all" to the {{VertexUpdateFunction}} and 
> {{MessagingFunction}}, that would indicate the type of neighborhood.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to