[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982936#comment-15982936 ]
Ufuk Celebi commented on FLINK-6337: ------------------------------------ Just double checked this and I think you are right. We currently use the buffer provider only for the buffer size which doesn't make sense. +1 to remove. I agree that the server handler is not a good place for it anyways (I think that was a work around in the initial version that is not needed any more). Could you make this refactoring an independent pull request so that we can review it easily? > Remove the buffer provider from PartitionRequestServerHandler > ------------------------------------------------------------- > > Key: FLINK-6337 > URL: https://issues.apache.org/jira/browse/FLINK-6337 > Project: Flink > Issue Type: Improvement > Components: Network > Reporter: zhijiang > Assignee: zhijiang > Priority: Minor > > Currently, {{PartitionRequestServerHandler}} will create a > {{LocalBufferPool}} when the channel is registered. The {{LocalBufferPool}} > is only used to get segment size for creating read view in > {{SpillableSubpartition}}, and the buffers in the pool will not be used all > the time, so it will waste the buffer resource of global pool. > We would like to remove the {{LocalBufferPool}} from the > {{PartitionRequestServerHandler}}, and the {{LocalBufferPool}} in > {{ResultPartition}} can also provide the segment size for creating sub > partition view. -- This message was sent by Atlassian JIRA (v6.3.15#6346)