Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3770#discussion_r113412507
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertexID.java
---
@@ -40,6 +40,10 @@ public JobVertexID(long lowerPart, long upperPart) {
super(lowerPart, upperPart);
}
+ public JobVertexID(AbstractID id) {
--- End diff --
Different subclasses of AbstractID are intended to introduce some kind of
type safety. With this in mind, I feel like this is a not very transparent way
of "casting" between Ids. Maybe some `convert` methods could make this a bit
more explicit than offering a public constructor for this purpose?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
