Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3770#discussion_r113416026
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java ---
@@ -133,11 +142,15 @@ public JobVertex(String name, JobVertexID id) {
* @param name The name of the new job vertex.
* @param primaryId The id of the job vertex.
* @param alternativeIds The alternative ids of the job vertex.
+ * @param operatorIds The ids of all operators contained in this job
vertex.
+ * @param alternativeOperatorIds The alternative ids of all operators
contained in this job vertex-
*/
- public JobVertex(String name, JobVertexID primaryId, List<JobVertexID>
alternativeIds) {
+ public JobVertex(String name, JobVertexID primaryId, List<OperatorID>
alternativeIds, List<OperatorID> operatorIds, List<OperatorID>
alternativeOperatorIds) {
--- End diff --
Again, generic Type on the third parameter seems off. I also suggest to
introduce line breaks to the parameter list as it is very long. On top of that,
we have a lot of parameter with the same type, which callers always can mix up
easily. This and the number of arguments make me wonder if it would make sense
to just have the actual Ids in the constructor, plus 2 methods to provide the
alternative IDs for the cases that require them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
