[
https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988926#comment-15988926
]
ASF GitHub Bot commented on FLINK-6337:
---------------------------------------
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/3785#discussion_r113946358
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -68,7 +68,11 @@ public static void shutdown() {
@Override
ResultSubpartition createSubpartition() {
- return new SpillableSubpartition(0,
mock(ResultPartition.class), ioManager);
+ ResultPartition parent = mock(ResultPartition.class);
--- End diff --
I guess you want to reuse this mocked `ResultPartition` in all the internal
tests, and I notice that there already exists `createSubpartition` override
method in this test, so I can modify the return type of `SpillableSubpartition`
instead. Do you think so?
> Remove the buffer provider from PartitionRequestServerHandler
> -------------------------------------------------------------
>
> Key: FLINK-6337
> URL: https://issues.apache.org/jira/browse/FLINK-6337
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
>
> Currently, {{PartitionRequestServerHandler}} will create a
> {{LocalBufferPool}} when the channel is registered. The {{LocalBufferPool}}
> is only used to get segment size for creating read view in
> {{SpillableSubpartition}}, and the buffers in the pool will not be used all
> the time, so it will waste the buffer resource of global pool.
> We would like to remove the {{LocalBufferPool}} from the
> {{PartitionRequestServerHandler}}, and the {{LocalBufferPool}} in
> {{ResultPartition}} can also provide the segment size for creating sub
> partition view.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
