Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3913#discussion_r116721391
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -34,41 +34,33 @@ trait ExternalCatalog {
/**
* Get a table from the catalog
*
- * @param dbName The name of the table's database.
* @param tableName The name of the table.
- * @throws DatabaseNotExistException thrown if the database does not
exist in the catalog.
* @throws TableNotExistException thrown if the table does not exist
in the catalog.
* @return the requested table
*/
- @throws[DatabaseNotExistException]
@throws[TableNotExistException]
- def getTable(dbName: String, tableName: String): ExternalCatalogTable
+ def getTable(tableName: String): ExternalCatalogTable
/**
* Get a list of all table names of a database in the catalog.
*
- * @param dbName The name of the database.
- * @throws DatabaseNotExistException thrown if the database does not
exist in the catalog
* @return The list of table names
*/
- @throws[DatabaseNotExistException]
- def listTables(dbName: String): JList[String]
+ def listTables(): JList[String]
/**
* Gets a database from the catalog.
*
- * @param dbName The name of the database.
- * @throws DatabaseNotExistException thrown if the database does not
exist in the catalog
* @return The requested database
*/
@throws[DatabaseNotExistException]
- def getDatabase(dbName: String): ExternalCatalogDatabase
+ def getSubCatalog(dbName: String): ExternalCatalog
/**
* Gets a list of all databases in the catalog.
*
* @return The list of database names
*/
- def listDatabases(): JList[String]
+ def listSubCatalog(): JList[String]
--- End diff --
+s `listSubCatalogs()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
