Github user haohui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3913#discussion_r117325036
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
 ---
    @@ -37,25 +36,10 @@ import org.apache.flink.table.plan.stats.TableStats
       * @param lastAccessTime       Timestamp of last access of the table
       */
     case class ExternalCatalogTable(
    -    identifier: TableIdentifier,
    --- End diff --
    
    I agree that it requires keeping more than the name of the table. The more 
general problem is that you will need to keep additional information for other 
data sources (e.g., the clusters for Kafka topics)
    
    I think it might make more sense to put the information at the properties 
field in `ExternalCatalogTable`. Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to