Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3934#discussion_r117452728
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchApiCallBridge.java
---
@@ -40,12 +43,27 @@
/**
* Creates an Elasticsearch {@link Client}.
*
+ * In comparison to {@link initClient}, this method creates a default
{@link Client}.
+ *
* @param clientConfig The configuration to use when constructing the
client.
* @return The created client.
*/
Client createClient(Map<String, String> clientConfig);
--- End diff --
The `ElasticsearchApiCallBridge` actually isn't a user-facing class, only
an interface for our version-specific implementations. So I think it is ok to
alter the interface freely.
In that case, it shouldn't be necessary to have a new method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
