Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/3934
  
    Answer to some of your other questions:
    
    1. I don't think the Apache ICLA is strictly required, unless you're 
invited as a Committer of the project.
    
    2. The tests should be added under `src/test/...` directory of the module. 
I think the already-existing IT tests for the ES sinks already cover the 
changed functionality here. Since this isn't a very complicated feature, for 
new tests, at the very most I would suggest perhaps to add unit tests that test 
the factory is correctly respected during the init flow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to