[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

[Zhe Li (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036675#comment-16036675
 ] 

Zhe Li commented on FLINK-6602:
-------------------------------

Checking the rowtime and proctime are not allowed empty string in 
StreamTableEnvironment#validateAndExtractTimeAttributes when called 
registerDataStreamInternal method, such as below code (added on line 485):

// rowtime and proctime are not allowed empty string
    if (rowtime.isDefined && rowtime.get._2.trim == "") {
      throw new TableException(
        "The rowtime attribute are not allowed empty string.")
    }

    if (proctime.isDefined && rowtime.get._2.trim == "") {
      throw new TableException(
        "The proctime attribute are not allowed empty string.")
    }

Is it right?

> Table source with defined time attributes allows empty string
> -------------------------------------------------------------
>
>                 Key: FLINK-6602
>                 URL: https://issues.apache.org/jira/browse/FLINK-6602
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Timo Walther
>
> {{DefinedRowtimeAttribute}} and {{DefinedProctimeAttribute}} are not checked 
> for empty strings.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)