[
https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046298#comment-16046298
]
Zhe Li commented on FLINK-6602:
-------------------------------
Timo & Fabian,
I have 2 problems to confirm.
(1) I think this problem only appeared when called
StreamTableSourceTable#getRowType method, but not
StreamTableEnvironment#validateAndExtractTimeAttributes, so we should check in
the method of getRowType, line 42 and 50, is it right?
(2) When check timeSource.getRowtimeAttribute or
timeSource.getProctimeAttribute is null or not, (line 42 and 50), we should add
codes to check whether 'XXXXAttribute' is empty string, if yes, we can treat
it as None. Such as following codes:
//case timeSource: DefinedRowtimeAttribute if timeSource.getRowtimeAttribute !=
null =>
case timeSource: DefinedRowtimeAttribute if timeSource.getRowtimeAttribute !=
null && !timeSource.getRowtimeAttribute.trim.equals("") =>
...
//case timeSource: DefinedProctimeAttribute if timeSource.getProctimeAttribute
!= null =>
case timeSource: DefinedProctimeAttribute if timeSource.getProctimeAttribute !=
null && !timeSource.getProctimeAttribute.trim.equals("") =>
is it right?
Thanks.
> Table source with defined time attributes allows empty string
> -------------------------------------------------------------
>
> Key: FLINK-6602
> URL: https://issues.apache.org/jira/browse/FLINK-6602
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Timo Walther
>
> {{DefinedRowtimeAttribute}} and {{DefinedProctimeAttribute}} are not checked
> for empty strings.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
