Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4145#discussion_r123184832
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -1131,6 +1152,7 @@ private void serializeStates(Set<State<T>> states, 
DataOutputView out) throws IO
                                        
nameSerializer.serialize(transition.getTargetState().getName(), out);
                                        
actionSerializer.serialize(transition.getAction(), out);
     
    +                                   // backward compatibility
                                        
serializeCondition(transition.getCondition(), out);
    --- End diff --
    
    Yes, but I think we could increase the VERSION field, and wrap this line in 
`if (readVersion == 1) {...}`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to