Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123192355 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -126,6 +129,7 @@ public AbstractKeyedCEPPatternOperator( this.isProcessingTime = Preconditions.checkNotNull(isProcessingTime); this.keySerializer = Preconditions.checkNotNull(keySerializer); this.nfaFactory = Preconditions.checkNotNull(nfaFactory); + this.conditionRegistry = nfaFactory.createNFA().getConditionRegistry(); --- End diff -- I am ok that `NFA` right now has pointer to `conditionRegistry`. The thing I meant is just in this line, as we call `createNFA()` and ignore the created `NFA`. The `nfaFactory` also has a pointer to the same `nfaRegistry` so instead of `nfaFactory.createNFA().getConditionRegistry()` we could call `nfaFactory.getConditionRegistry()`. What do you think?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---