[ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058919#comment-16058919 ]
ASF GitHub Bot commented on FLINK-6938: --------------------------------------- Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4145#discussion_r123439484 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java --- @@ -36,24 +34,14 @@ private final StateTransitionAction action; private final State<T> sourceState; private final State<T> targetState; - private IterativeCondition<T> newCondition; - - /** - * @deprecated This field remains for backwards compatibility. - * Now the conditions extend the {@link IterativeCondition}. - */ - @Deprecated - private FilterFunction<T> condition; --- End diff -- I think this field needs to stay, though. It was prior to 1.3.x, so it is needed for java serialization, which is used for snapshots taken in 1.2.x > IterativeCondition should support RichFunction interface > -------------------------------------------------------- > > Key: FLINK-6938 > URL: https://issues.apache.org/jira/browse/FLINK-6938 > Project: Flink > Issue Type: Sub-task > Components: CEP > Reporter: Jark Wu > Assignee: Jark Wu > Fix For: 1.4.0 > > > In FLIP-20, we need IterativeCondition to support an {{open()}} method to > compile the generated code once. We do not want to insert a if condition in > the {{filter()}} method. So I suggest make IterativeCondition support > {{RichFunction}} interface. -- This message was sent by Atlassian JIRA (v6.4.14#64029)