[ 
https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058920#comment-16058920
 ] 

ASF GitHub Bot commented on FLINK-6938:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4145#discussion_r123439602
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/StateTransition.java
 ---
    @@ -98,32 +82,9 @@ public int hashCode() {
     
        @Override
        public String toString() {
    -           return new StringBuilder()
    -                           .append("StateTransition(")
    -                           .append(action).append(", ")
    -                           .append("from ").append(sourceState.getName())
    -                           .append("to ").append(targetState.getName())
    -                           .append(newCondition != null ? ", with 
condition)" : ")")
    -                           .toString();
    -   }
    -
    -   /**
    -    * A wrapper to transform a {@link FilterFunction} into a {@link 
SimpleCondition}.
    -    * This is used only when migrating from an older Flink version.
    -    */
    -   private static class FilterWrapper<T> extends SimpleCondition<T> {
    --- End diff --
    
    Same as above.


> IterativeCondition should support RichFunction interface
> --------------------------------------------------------
>
>                 Key: FLINK-6938
>                 URL: https://issues.apache.org/jira/browse/FLINK-6938
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> In FLIP-20, we need IterativeCondition to support an {{open()}} method to 
> compile the generated code once. We do not want to insert a if condition  in 
> the {{filter()}} method. So I suggest make IterativeCondition support 
> {{RichFunction}} interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to