[ 
https://issues.apache.org/jira/browse/FLINK-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570509#comment-14570509
 ] 

ASF GitHub Bot commented on FLINK-1993:
---------------------------------------

Github user thvasilo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/760#discussion_r31604864
  
    --- Diff: 
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
 ---
    @@ -309,8 +207,10 @@ object MultipleLinearRegression {
           : DataSet[LabeledVector] = {
    --- End diff --
    
    Docstring for the return type?


> Replace MultipleLinearRegression's custom SGD with optimization framework's 
> SGD
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-1993
>                 URL: https://issues.apache.org/jira/browse/FLINK-1993
>             Project: Flink
>          Issue Type: Task
>          Components: Machine Learning Library
>            Reporter: Till Rohrmann
>            Assignee: Theodore Vasiloudis
>            Priority: Minor
>              Labels: ML
>             Fix For: 0.9
>
>
> The current implementation of MultipleLinearRegression uses a custom SGD 
> implementation. Flink's optimization framework also contains a SGD optimizer 
> which should replace the custom implementation once the framework is merged.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to